-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big refactor and mobile transitions (issue 286) #297
Comments
The animation API has been integrated since forever ago. All I did was refactor it. As far as mobile support, I'm not aware of any elements of UI Router that make it unsuitable for use in mobile browsers. Quite the opposite, in fact (including animation, which works smoothly on iOS). I'm not aware of any benefits, mobile-specific or otherwise, that |
The problem is there is discussion there to continue work on angular-mobile-nav or angular-jqm to use them for a basic alternative routing and view transition framework (ajoslin/angular-mobile-nav#48 (comment)). Of course Andy does great work and is free to work on anything he sees fit, but it's worth taking a second to ask why in this case as a sanity check for ui-router. Are there common scenarios in mobile apps that are not covered? I did try to verify basic iOS style push transitions work here: http://plnkr.co/0nCW8U |
...I'm not sure how that has any bearing on this project.
The goals of this project have been clear since the beginning. I'm sure you probably already saw them in the readme. Particularly given the stats of this project compared to the ones you mention, I think we're good without a sanity check, thanks anyway.
Indeed, ui-router supports any and all animations supported by Angular's native
I won't pretend to try and read your mind with regard to what constitutes a 'common scenario' in a mobile app. You're welcome to evaluate this project and make your own determination as to whether it's suitable for your needs. I'm going to close this now, as it doesn't seem to be going anywhere. If there are specific, articulable features that fall within the goals of this project that you'd like to see implemented, by all means, please open a new issue. If there are any specific, articulable ways in which we are not supporting 'common scenarios in mobile apps', by all means, open a new issue that specifically and clearly demonstrates what and how. But please, no more fishing expeditions asking 'how does X compare to Y?'. We have enough of our own work to do here. We don't need to do yours, too. |
If my comments are not productive for you I'm glad to respect your wishes and not discuss it here. That said, my goal is not to get you "do my work" and the question does "have...bearing on this project". I saw work was planned for related Angular projects that looked like it was overlapping. If there is overlap for the wrong reasons this could waste time for those contributing or using the projects. If the overlap is there for a valid reason, I don't see why anyone should object to a question asked in good faith. |
Near as I can tell, the projects you mention are (a) mostly directives, and (b) operate on a very narrowly-defined, mobile-only concept, explicitly modeled after jQuery Mobile. The goals of this project (again, as far as I can tell) are quite different, in that it aims to be a generic interface for managing UI state and navigation, that works equally well on any platform. To reiterate, if there are any specific, articulable ways we can better support mobile interfaces, please let us know, but I would suggest looking at
Motivations are subjective, and Open Source is not a zero-sum game. This is not a useful line of reasoning. |
I've read through issue 286, but have a question. Is this the first change that will use the new animation support in Angular 1.1.5?
I'm concerned that the whole world is embracing mobile as a core scenario yet the angular community is investing in ui-router AND angular-mobile-nav, even though it seems the latter should be a basic part of ui-router.
https://github.com/ajoslin/angular-mobile-nav
The text was updated successfully, but these errors were encountered: