This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
fix(_updateItemLocked) properly unlock locked items when lock conditions change #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons change Previously when the lock expression value changes from true to false the locked value was not removed from the locked list.
|
Should probably be a test that caught this but we'll just quietly slide this in while no-ones looking... Thanks 😄 |
Jefiozie
pushed a commit
to Jefiozie/ui-select
that referenced
this pull request
Oct 31, 2016
…hange Previously when the lock expression value changes from true to false the locked value was not removed from the locked list. Closes angular-ui#1824
kboga
pushed a commit
to kboga/ui-select
that referenced
this pull request
Nov 29, 2016
…hange Previously when the lock expression value changes from true to false the locked value was not removed from the locked list. Closes angular-ui#1824
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the lock expression value changes from true to false the locked value was not removed from the locked list.