Skip to content

Commit

Permalink
fix(@angular/cli): remove broken script after eject
Browse files Browse the repository at this point in the history
`prepree2e` doesn't run because it's a lifecycle script for a lifecycle script, but even if it did it would not work because there is nothing coordinating the serve and e2e processes.

Users must manually initialize the server prior to running e2e tests after ejecting.

Related to #6171
  • Loading branch information
filipesilva authored and Brocco committed May 24, 2017
1 parent 3f10c5a commit 2b0d935
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions packages/@angular/cli/tasks/eject.ts
Original file line number Diff line number Diff line change
Expand Up @@ -427,12 +427,6 @@ export default Task.extend({
Your package.json scripts must not contain a start script as it will be overwritten.
`);
}
if (scripts['pree2e'] && scripts['prepree2e'] !== 'npm start' && !force) {
throw new SilentError(oneLine`
Your package.json scripts needs to not contain a prepree2e script as it will be
overwritten.
`);
}
if (scripts['pree2e'] && scripts['pree2e'] !== pree2eNpmScript && !force) {
throw new SilentError(oneLine`
Your package.json scripts must not contain a pree2e script as it will be
Expand All @@ -453,7 +447,6 @@ export default Task.extend({
packageJson['scripts']['build'] = 'webpack';
packageJson['scripts']['start'] = 'webpack-dev-server --port=4200';
packageJson['scripts']['test'] = 'karma start ./karma.conf.js';
packageJson['scripts']['prepree2e'] = 'npm start';
packageJson['scripts']['pree2e'] = pree2eNpmScript;
packageJson['scripts']['e2e'] = 'protractor ./protractor.conf.js';

Expand Down

0 comments on commit 2b0d935

Please sign in to comment.