fix(@angular/cli): Fix config command setting number values

fixes #10900
angular · May 29, 2018 · 6d80c49 · 6d80c49
1 parent 4f9fd9f
commit 6d80c49
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/@angular/cli/commands/config.ts b/packages/@angular/cli/commands/config.ts
@@ -151,7 +151,11 @@ function normalizeValue(value: string, path: string): JsonValue {
     throw new Error(`Invalid value type; expected a ${cliOptionType}.`);
   }
 
-  return parseJson(value, JsonParseMode.Loose);
+  if (typeof value === 'string') {
+    return parseJson(value, JsonParseMode.Loose);
+  }
+
+  return value;
 }
 
 export default class ConfigCommand extends Command {

diff --git a/tests/e2e/tests/commands/config/config-set-serve-port.ts b/tests/e2e/tests/commands/config/config-set-serve-port.ts
@@ -0,0 +1,8 @@
+import { expectFileToMatch } from '../../../utils/fs';
+import { ng } from '../../../utils/process';
+
+export default function() {
+  return Promise.resolve()
+    .then(() => ng('config', 'projects.test-project.architect.serve.options.port', '1234'))
+    .then(() => expectFileToMatch('angular.json', /"port": 1234/));
+}