Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible peer dependencies found when updating a brand new project #11138

Closed
willgm opened this issue Jun 6, 2018 · 7 comments
Closed

Incompatible peer dependencies found when updating a brand new project #11138

willgm opened this issue Jun 6, 2018 · 7 comments

Comments

@willgm
Copy link

willgm commented Jun 6, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Area

- [ ] devkit
- [x] schematics

Versions

Angular CLI: 6.0.8
Node: 8.9.0
OS: linux x64
Angular: 6.0.4

Repro steps

ng new my-proj
cd my-proj
ng update --all

The log given by the failure

                  Package "karma-jasmine-html-reporter" has a missing peer dependency of "jasmine" @ ">=3".
                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=2.7.2 <2.8", would install "2.9.1").
Incompatible peer dependencies found. See above.

Desired functionality

To have a successful message.

@tsu-la
Copy link

tsu-la commented Jun 7, 2018

I also ran into this issue and trying to install typescript 2.8 installs version 2.8.4 which also gives an error.

@aphexddb
Copy link

aphexddb commented Jun 7, 2018

Also seeing this when migrating an older project.

Versions

Angular CLI: 6.0.8
Node: 8.9.4
OS: OSX 10.13.5
Angular: 4.4.7

Repro steps

ng update --all

The log given by the failure

                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=2.7.2 <2.8", would install "2.9.1")
                  Package "@angular/compiler-cli" has an incompatible peer dependency to "typescript" (requires ">=2.7.2 <2.8", would install "2.9.1").
Incompatible peer dependencies found. See above.

@hansl
Copy link
Contributor

hansl commented Jun 7, 2018

Hi @aphexddb,

Unfortunately, this one comes down as a feature. ng update --all will still validate that all dependencies are compatible with each others, but typescript's latest is 2.9, which isn't compatible with Angular's compiler. You can use ng update --all --force to force the update, or just update dependencies one at a time.

Now there's a case to be made that --all should be smarter and only update compatible versions. I think we need a feature in the future (e.g. --smart) that would do that, but in the meantime this is the best that makes sense.

Closing this as working as intended.

@hansl hansl closed this as completed Jun 7, 2018
@willgm
Copy link
Author

willgm commented Jun 7, 2018

Hi @hansl,

In a new project, if we run just ng update is says that there is nothing to update, but if we use the flag --all it gives this "incompatible peer dependency" error. It looks contradictory or at least confusing for me. Shouldn't the --all flag just execute what is at the ng update list? And do nothing if it is empty?

@Trapulo
Copy link

Trapulo commented Jun 12, 2018

ame error updating an existing project from angular 5.2 to 6.0.4

@Fieel
Copy link

Fieel commented Dec 12, 2018

Any news on this? I installed Typescript 3.1.6 as a workaround and have no problems.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants