refactor(@angular/schematics): Add an extra option to not use dasheri… #12500
Conversation
vikerman
force-pushed
the
master
branch
2 times, most recently
from
cabfb37
to
bcaf37e
Compare
| @@ -42,8 +43,9 @@ export function findModuleFromOptions(host: Tree, options: ModuleOptions): Path | |||
| const routingModuleExt = options.routingModuleExt || ROUTING_MODULE_EXT; | |||
|
|
|||
| if (!options.module) { | |||
| options.normalizeName = options.normalizeName || strings.dasherize; | |||
There was a problem hiding this comment.
Instead of allowing for overwriting the name, why don't you let the parent pass in the formatting function (with dasherize being the default)? We have strings.underscore() which would allow you to format the name properly in google, whichever the input. What do you think?
There was a problem hiding this comment.
Ugh Sorry. I think the variable is badly named. This is exactly what I'm trying to do.
normalizeName?: (str: string) => string;
Renamed it to nameFormatter.
…ptions In Google we prefer underscore instead of dashes. So this options is useful there.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…ze in findModuleFromOptions
In Google we prefer underscore instead of dashes. So this option is useful there.