Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass forked type checker Semantic errors to the output when running build --watch #13901

Open
Usurer opened this Issue Mar 13, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Usurer
Copy link

Usurer commented Mar 13, 2019

馃殌 Feature request

Command (mark with an x)

- [ ] new
- [x] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

As described in #13870 semantic diagnostic errors from the forked type checker aren't passed to the final diagnostic messages and cannot be read by Webpack plugins. This happens during second and further runs of the build --watch.

Describe the solution you'd like

The straightforward solution would be to add one more option to the ng build.
But, since I don't really get why we don't collect semantic diagnostics from the forked type checker for the 2-nd and further runs, I'd say that we could just set diagMode in AngularCompilerPlugin._emit() to DiagnosticMode.All.

Describe alternatives you've considered

The working solution is to set forkTypeChecker build option to false. But my assumption is that on the big projects it means slower builds.

@Usurer

This comment has been minimized.

Copy link
Author

Usurer commented Mar 16, 2019

Guys, could anyone give any advice regarding the way I should test this feature before making a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.