-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(): Adding es6 shims and system polyfills. Those are required by IE. #141
Conversation
@@ -41,8 +41,10 @@ Angular2App.prototype.toTree = function () { | |||
'angular2/bundles/http.dev.js', | |||
'angular2/bundles/router.dev.js', | |||
'angular2/bundles/upgrade.dev.js', | |||
'es6-shim/es6-shim.js' | |||
'rxjs/bundles/Rx.js', | |||
'systemjs/dist/system.src.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot a comma here, and on the shim line as well.
@@ -41,8 +41,10 @@ Angular2App.prototype.toTree = function () { | |||
'angular2/bundles/http.dev.js', | |||
'angular2/bundles/router.dev.js', | |||
'angular2/bundles/upgrade.dev.js', | |||
'es6-shim/es6-shim.js', | |||
'rxjs/bundles/Rx.js', | |||
'systemjs/dist/system.src.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma missing
can you also add a conditional comment to to the index.html blueprint to load these scripts on older IEs |
otherwise lgtm |
@hansl could you rebase on master? Then we can merge it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.