Revert "fix(@angular-devkit/build-angular): remove pure_getters" #14287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
approved these changes
Apr 26, 2019
This reverts commit 9a9939f. We are temporarily reverting the pure_getters removal because it caused a 2x size regression in Ivy (non-compatibility mode). We need time to investigate why this is happening and re-assess how we want to move forward. See angular/angular@fcacb2a for size regression.
kara
force-pushed
the
revert-pure-getters
branch
from
7873f75
to
b36ca6f
Compare
|
Related to #14187 |
alexeagle
pushed a commit
that referenced
this pull request
Apr 27, 2019
Revert "fix(@angular-devkit/build-angular): remove pure_getters"
This was referenced Apr 30, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9a9939f.
We are temporarily reverting the pure_getters removal because it caused a 2x size
regression in Ivy (non-compatibility mode). We need time to investigate why this
is happening and re-assess how we want to move forward.
See angular/angular@fcacb2a for size regression.