fix(@schematics/update): improve error message when finding incompati… #14578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
filipesilva
added
the
needs: discussion
|
LGTM but just tagging it for discussion around the message in the triage meeting. |
|
I think it should also warning about potentially breaking the project as a result. |
filipesilva
reviewed
May 30, 2019
| @@ -214,7 +214,9 @@ function _validateUpdatePackages( | |||
| }); | |||
|
|
|||
| if (!force && peerErrors) { | |||
| throw new SchematicsException(`Incompatible peer dependencies found. See above.`); | |||
| throw new SchematicsException(tags.stripIndents | |||
| `Incompatible peer dependencies found. See above. | |||
There was a problem hiding this comment.
WDYT of changing it to this for now, then we talk to the docs folks?
Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.
filipesilva
approved these changes
May 30, 2019
…ble peer dependencies fix #14562
alan-agius4
removed
the
needs: discussion
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble peer dependencies
fix #14562