Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): re-order ES5 polyfills in karma H… #14693

Merged
merged 1 commit into from Jun 6, 2019
Merged

fix(@angular-devkit/build-angular): re-order ES5 polyfills in karma H… #14693

merged 1 commit into from Jun 6, 2019

Conversation

alan-agius4
Copy link
Collaborator

…TMLs

Similar to the index HTML page (

await expectFileToMatch('dist/test-project/index.html', oneLineTrim`
<script src="runtime.js"></script>
<script src="polyfills-es5.js" nomodule></script>
<script src="polyfills.js"></script>
<script src="styles.js"></script>
<script src="vendor.js"></script>
<script src="main.js"></script>
`);
) ES5 polyfills should be loaded prior to the other polyfills. This is because other polyfills such as zone.js require these for example Symbol and Object.isFrozen

Fixes #14618

…TMLs

Similar to the index HTML page (https://github.com/angular/angular-cli/blob/6ec09919b5c2695dee784ce0c3accee7f9754bb0/tests/legacy-cli/e2e/tests/misc/support-ie.ts#L30-L37) ES5 polyfills should be loaded prior to the other polyfills. This is because other polyfills such as `zone.js` require these for example `Symbol` and `Object.isFrozen`

Fixes #14618
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 6, 2019
@alexeagle alexeagle merged commit 8828a7d into angular:master Jun 6, 2019
@alan-agius4 alan-agius4 deleted the karma-es5-polyfills branch June 6, 2019 21:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with ancient Chrome/Chromium after update to v8.0
4 participants