feat(generate): add directives #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cironunes
force-pushed
the
generate-directives
branch
from
274fa93
to
a013281
Compare
|
LGTM. |
|
I'd suggest adding some information about the new generation in the readme as part of this PR |
|
Yes, readme should be included. |
|
Thanks for the feedback guys. I took the opportunity to improve the whole scaffolding session on the README. Please take a look and let me know if we can merge this in. |
|
👍 for aliases. |
|
lgtm 👍 |
cironunes
force-pushed
the
generate-directives
branch
from
0ed77db
to
5dcdf51
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148