Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e osx #151

Merged
merged 2 commits into from
Jan 25, 2016
Merged

E2e osx #151

merged 2 commits into from
Jan 25, 2016

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented Jan 25, 2016

@cironunes
Copy link
Member

Great! LGTM

@jkuri
Copy link
Contributor Author

jkuri commented Jan 25, 2016

Thanks for helping man.
Now tests are taking much longer since travis needs to install nvm before running any tests.

@filipesilva
Copy link
Contributor

lgtm as well, merging.

@filipesilva
Copy link
Contributor

Eh wait, can't do it without a rebase atm. Can you rebase on top of master @jkuri ?

@jkuri
Copy link
Contributor Author

jkuri commented Jan 25, 2016

Sure, rebased.

@filipesilva filipesilva merged commit 6560455 into angular:master Jan 25, 2016
@filipesilva filipesilva mentioned this pull request Jan 28, 2016
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkuri @cironunes @filipesilva