-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 12.1.1 loads both the generated es5 as well as es2015 bundles #15106
Comments
This is actually a known issue with Safari 11+ that can happen in certain situtations (https://bugs.webkit.org/show_bug.cgi?id=194337). Note this point in the bug report:
Removing the inline script element added in the reproduction and serving normally (without a server that injects additional scripts into the HTML) causes only the ES2015 files to be fetched as expected. |
@clydin Thanks for clarification. |
A new CLI app will work when served normally. The presence of classic scripts are the issue here which most live reload servers will inject into the HTML prior to serving (and which your demo app is also adding which is triggering the issue). |
Thanks for your reply @clydin. The problem in our application is that on top of Angular CLI injected script tags, we've got a legacy ES5 javascript code inside
Now if we want to make use of differential loading under Safari, I guess we would need to change it it:
But the problem is that the code is ES5 and not a valid ES2015 module, example the Do you see any possible solution to this using Safari? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
馃悶 Bug report
Command (mark with an
x
)Is this a regression?
I did not check that!
Description
Safari
12.1.1
loads both the generatedes5
as well ases2015
bundles.馃敩 Minimal Reproduction
See this repo with the provided details about how to reproduce the issue.
馃敟 Exception or Error
馃實 Your Environment
Anything else relevant?
I'm observing the issue only on Safari
12.1.1
and did not check the other versions of it. I also don't see this behaviour on OS X10.13.6
using Chrome75.0.3770.142
or Firefox68.0 (64-bit)
The text was updated successfully, but these errors were encountered: