Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update saucelabs protractor config to run e2e tests in series rather than parallel #15545

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

josephperrott
Copy link
Member

Our combined CI usage is often hitting the max number of concurrent sessions on saucelabs. Currentl the saucelabs job takes 12 sessions at once because the tests run in parallel, instead we should run these in series to only use 1 session.

It should not have a large impact on overall CI run time as each of the tests take ~10 seconds so we are moving from the Saucelabs steps taking ~1:45 to ~3:00 each. Based on previous CI runs it looks like this change will still cause the saucelabs test runs to complete ~15 minutes before other jobs in the sequence.

@josephperrott josephperrott added area: etc/misc target: major This PR is targeted for the next major release labels Sep 6, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Sep 6, 2019

@josephperrott any reason why we should not backport this to patch branch?

Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, average total runtime of the current test-browsers appears to increase from ~5 minutes to ~10 minutes.

@josephperrott
Copy link
Member Author

@alan-agius4 no, I suppose that we should be able to run it on any branch. Will update label

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Sep 6, 2019
@kyliau kyliau merged commit b204dd8 into angular:master Sep 10, 2019
@josephperrott josephperrott deleted the saucelabs-series branch September 10, 2019 17:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: etc/misc target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants