feat(@angular-devkit/build-angular): add support for i18n extraction … #15796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with Ivy Re-enable i18n extraction in Ivy by using the legacy VE compiler.
alan-agius4
added
target: major
filipesilva
approved these changes
Oct 9, 2019
clydin
approved these changes
Oct 9, 2019
clydin
reviewed
Oct 9, 2019
There was a problem hiding this comment.
Couple additional actions I think we should do for the command:
- Deprecate “i18nFormat” in favor of the more succinct “format”. The current option is awkward on the command line and the command is already called “xi18n”.
- Deprecate “i18nLocale” completely. It’s not needed with the new configuration; source locale is already defined.
- Consider renaming (or adding an alias for) the command to “i18n-extract” or “translate-extract” or similar. “xi18n” is not obvious as to function.
This was referenced Oct 11, 2019
Closed
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…with Ivy
Re-enable i18n extraction in Ivy by using the legacy VE compiler.