Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vendor): Fix to add concatenated vendors in index.html #165

Merged
merged 1 commit into from
Jan 31, 2016

Conversation

jkuri
Copy link
Contributor

@jkuri jkuri commented Jan 31, 2016

@cironunes, @filipesilva please check this soon as master still not working.

@filipesilva
Copy link
Contributor

It looks ok but you and @cironunes are the ones working on it, I don't have as much information as you two.

@jkuri
Copy link
Contributor Author

jkuri commented Jan 31, 2016

I now tested with "clean npm install", creating new project, linking, and I am pretty sure that this now works.

@jkuri
Copy link
Contributor Author

jkuri commented Jan 31, 2016

If you check current master its not working, and @cironunes seems to be away at the moment.

@filipesilva
Copy link
Contributor

Let's put it in then. Can't have master not working.

@filipesilva filipesilva merged commit e2c8795 into angular:master Jan 31, 2016
@jkuri jkuri deleted the vendor-libs-fix branch January 31, 2016 15:29
@jkuri
Copy link
Contributor Author

jkuri commented Jan 31, 2016

I re-checked on master now, and it is working. Thank you.

@filipesilva
Copy link
Contributor

👍

@cironunes
Copy link
Member

thanks @jkuri

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants