Add links to generated configs #17906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
We now add a link to generated tsconfig.json to make is easier for users to find relevant information.
We now add a link to generated app package.json to make is easier for users to find relevant information.
alan-agius4
commented
Jun 11, 2020
| @@ -34,7 +34,10 @@ export default function (): Rule { | |||
| const pkgJsonContent = { | |||
| name: strings.dasherize(projectName), | |||
| private: true, | |||
| description: `This is a special package.json file that is not used by package managers. It is however used to tell the tools and bundlers whether the code under this directory is free of code with non-local side-effect. Any code that does have non-local side-effects can't be well optimized (tree-shaken) and will result in unnecessary increased payload size. It should be safe to set this option to 'false' for new applications, but existing code bases could be broken when built with the production config if the application code does contain non-local side-effects that the application depends on.`, | |||
| description_1: 'This is a special package.json file that is not used by package managers.', | |||
There was a problem hiding this comment.
In VS code, this is unreadable because it will not be wrapped in multilines line in GitHub. Thus, I split it in multiple descriptions.
IgorMinar
approved these changes
Jun 12, 2020
clydin
approved these changes
Jun 12, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Blocked on: angular/angular#37533