Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@schematics/angular): remove reference to tsconfig.spec.json in tsconfig.json when minimal=true #18293

Merged
merged 1 commit into from Jul 20, 2020
Merged

fix(@schematics/angular): remove reference to tsconfig.spec.json in tsconfig.json when minimal=true #18293

merged 1 commit into from Jul 20, 2020

Conversation

Amit775
Copy link
Contributor

@Amit775 Amit775 commented Jul 18, 2020 •
edited by alan-agius4

fixes: #18288

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jul 18, 2020
alan-agius4
alan-agius4 approved these changes Jul 18, 2020
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@filipesilva filipesilva merged commit f4f5e0b into angular:master Jul 20, 2020
@Amit775 Amit775 deleted the fix/tsconfig_spec_json_when_minimal_true branch July 23, 2020 18:27
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ng-new --minimal: tsconfig.spec.json shouldn't be a reference in tsconfig.json
4 participants
@Amit775 @alan-agius4 @filipesilva @googlebot