Fixes publish script to require NPM tag, use Wombat registry, and correctly read check flags #18324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pure refactor that just pulls the Wombat registry into a separate string constant to be re-used across scripts.
Flag arguments provided by minimist are always strings. Both `--branchCheck` and `--versionCheck` failed to take this into account and were incorrectly typed as a result. Now boolean flags are parsed into actual boolean types which can be used more intuitively.
dgp1130
added
the
target: lts
kyliau
approved these changes
Jul 22, 2020
clydin
approved these changes
Jul 22, 2020
`--tag` now must be explicitly specified rather than defaulting to `latest`. It is also validated to be one of the expected set of tags. There is a new `--tagCheck false` flag that will skip this in order to handle one-off custom tags if necessary in the future. Apparently NPM requires that all releases have tags (defaulting to `latest` if not explicitly specified), so there is no way to choose **not** to push a new tag. That means that you can't push `10.0.x` and then push `9.0.x` without either using `v9-lts` or clobbering `latest`. The `--tag` requirement should hopefully enforce this restriction to avoid a potential release footgun.
|
This is stuck on 'Missing required status "ci/circleci: integration"'. Is there something more I need to do or is CI trying to run checks that don't exist on this branch? |
|
it doesn’t exists in this branch, I wonder if we should do a dump task
until Angular robot can handle this.
…On Wed, 22 Jul 2020 at 21:15, Douglas Parker ***@***.***> wrote:
This is stuck on 'Missing required status "ci/circleci: integration"'. Is
there something more I need to do or is CI trying to run checks that don't
exist on this branch?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#18324 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEF74WXQHYJKXKBSSV4ORO3R443FPANCNFSM4PEDM43A>
.
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch PR for #18219. The
dist-tagchanges are not present here because that script does not exist and would not be used from this branch.I also dropped the
doc:commit since we don't typically look at docs on the non-master branch.