Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use CircleCI pipeline SHA variables for commit validation #18350

Merged
merged 1 commit into from Jul 23, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 23, 2020

This also speeds up the validation checks because the GitHub API request method is no longer used.

@alan-agius4
Copy link
Collaborator

@googlebot ping.

@clydin clydin added the target: major This PR is targeted for the next major release label Jul 23, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 23, 2020
@alan-agius4 alan-agius4 merged commit c75ae25 into angular:master Jul 23, 2020
@clydin clydin deleted the commit-validation branch July 23, 2020 20:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants