Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): don't use parent modules while deduping #18438

Merged
merged 1 commit into from Aug 5, 2020
Merged

fix(@angular-devkit/build-angular): don't use parent modules while deduping #18438

merged 1 commit into from Aug 5, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 4, 2020

With this change we change the DedupeModuleResolvePlugin to act similar to NormalModuleReplacementPlugin

Closes #18396

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 4, 2020
@alan-agius4 alan-agius4 requested a review from clydin August 4, 2020 08:05
…duping

With this change we change the `DedupeModuleResolvePlugin` to act similar to `NormalModuleReplacementPlugin`

Closes: #18411
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): don't use parent don't modules while deduping fix(@angular-devkit/build-angular): don't use parent modules while deduping Aug 5, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 5, 2020
@clydin clydin merged commit eca08cc into angular:master Aug 5, 2020
@alan-agius4 alan-agius4 deleted the dedupe-plugin branch August 5, 2020 15:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular uses parent node_modules in build process
3 participants