Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): cleanup Webpack rule generation #18444

Merged
merged 1 commit into from Aug 5, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 4, 2020

This change reduces the number of variables needed as well as reduces type casting.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 4, 2020
@clydin clydin force-pushed the cleanup-webpack-rules branch 2 times, most recently from 1a63293 to f7bdf66 Compare August 4, 2020 15:54
This change reduces the number of variables needed as well as reduces type casting.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 5, 2020
@clydin clydin added target: major This PR is targeted for the next major release and removed target: major This PR is targeted for the next major release labels Aug 5, 2020
@clydin clydin merged commit 2f6b810 into angular:master Aug 5, 2020
@clydin clydin deleted the cleanup-webpack-rules branch August 5, 2020 12:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants