Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): support multiple translation files per locale #18508

Merged
merged 1 commit into from Aug 13, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Aug 12, 2020

This change implements the capability to specify multiple translation files per locale. The specified translation files for each locale will be merged prior to localization. The Angular configuration file has been updated to allow for both a single path string or an array of path strings when specifying the translations for each locale. If the same message identifier is present in multiple translation files, a warning will currently be issued and the last file with the duplicate message identifier will take precedence.

Closes #18276

…es per locale

This change implements the capability to specify multiple translation files per locale. The specified translation files for each locale will be merged prior to localization. The Angular configuration file has been updated to allow for both a single path string or an array of path strings when specifying the translations for each locale. If the same message identifier is present in multiple translation files, a warning will currently be issued and the last file with the duplicate message identifier will take precedence.

Closes angular#18276
@clydin clydin added the target: major This PR is targeted for the next major release label Aug 12, 2020
@clydin clydin marked this pull request as ready for review August 12, 2020 17:26
@alan-agius4 alan-agius4 self-requested a review August 13, 2020 10:22
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2020
@alan-agius4 alan-agius4 merged commit 9cd796b into angular:master Aug 13, 2020
@clydin clydin deleted the multi-translation-support branch August 13, 2020 10:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n - implement translation file merging
3 participants