Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support Webpack 5 in platform server E2E test #18786

Merged
merged 1 commit into from Sep 15, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 14, 2020

The platform server E2E test checks for a Webpack specific output to determine if the server module is present. This output is different for Webpack 5. This change tries to match either the Webpack 4 or Webpack 5 output.

The platform server E2E test checks for a Webpack specific output to determine if the server module is present.  This output is different for Webpack 5.  This change tries to match either the Webpack 4 or Webpack 5 output.
@clydin clydin added the target: major This PR is targeted for the next major release label Sep 14, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 15, 2020
@clydin clydin merged commit 0174de0 into angular:master Sep 15, 2020
@clydin clydin deleted the webpack-5-server-e2e branch September 15, 2020 10:26
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants