Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): fixed Module.issuer is deprecated in webpack 5 for commonjs warn plugin #18913

Merged

Conversation

valorkin
Copy link
Contributor

@valorkin valorkin commented Sep 28, 2020

Closes #18895

Should fix all or part of
225 warnings [DEP_WEBPACK_MODULE_ISSUER] DeprecationWarning: Module.issuer: Use new ModuleGraph API

@valorkin valorkin marked this pull request as ready for review September 28, 2020 15:01
@clydin clydin added the target: major This PR is targeted for the next major release label Sep 28, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Sep 28, 2020
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 28, 2020
@valorkin valorkin force-pushed the fix-webpack5-module-issuer-is-deprecated branch from 8c211e3 to 989b27d Compare September 28, 2020 17:52
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 28, 2020
@angular angular deleted a comment from ngbot bot Sep 28, 2020
@alan-agius4 alan-agius4 merged commit c8f8640 into angular:master Sep 28, 2020
@valorkin valorkin deleted the fix-webpack5-module-issuer-is-deprecated branch September 28, 2020 19:04
@valorkin
Copy link
Contributor Author

thanks :)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpack 5 warning
4 participants