feat(@angular-devkit/build-angular): enable font inlining optimizations #18926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
changed the title
kyliau
reviewed
Oct 14, 2020
packages/angular_devkit/build_angular/src/browser/specs/optimization-fonts_spec.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/browser/specs/optimization-fonts_spec.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts.ts
Outdated
Show resolved
Hide resolved
packages/angular_devkit/build_angular/src/utils/index-file/inline-fonts_spec.ts
Outdated
Show resolved
Hide resolved
| fonts: FontsClass, | ||
| }; | ||
|
|
||
| export function normalizeOptimization(optimization: OptimizationUnion = false): NormalizeOptimizationOptions { |
There was a problem hiding this comment.
Not exactly sure what the default value here means - isn't the default in the schema true?
There was a problem hiding this comment.
Strictly speaking the default is defined in the schema which is false. But in the typings these are still marked as optional.
packages/angular_devkit/build_angular/src/utils/process-bundle.ts
Outdated
Show resolved
Hide resolved
This is the base functionality needed to inline Google fonts and Icons in HTML. The processor does a couple of things: 1. When support for older devices is needed where woff2 is not supported it will inline definitions for both woff1 and woff2 2. Will remove comments and whitespaces when it's `minifyInlinedCSS` is enabled. 3. Cache responses so to resuse the font response during watch mode. Note: this is still an internal implementation which users cannot leverage just yet.
kyliau
approved these changes
Oct 14, 2020
With this change we inline Google fonts and icons in the index html file when optimization is enabled. **Before** ```html <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons"> ``` **After** ```html <style> @font-face { font-family: 'Material Icons'; font-style: normal; font-weight: 400; src: url(https://fonts.gstatic.com/s/materialicons/v55/flUhRq6tzZclQEJ-Vdg-IuiaDsNcIhQ8tQ.woff2) format('woff2'); } .material-icons { font-family: 'Material Icons'; font-weight: normal; font-style: normal; font-size: 24px; line-height: 1; letter-spacing: normal; text-transform: none; display: inline-block; white-space: nowrap; word-wrap: normal; direction: ltr; } </style> ``` To opt-out of this feature set `optimization.fonts: false` or `optimization.fonts.inline: false` in the browser builder options. Example: ```js "configurations": { "production": { "fileReplacements": [ { "replace": "src/environments/environment.ts", "with": "src/environments/environment.prod.ts" } ], "optimization": { "fonts": false }, ``` More information about the motivation for this feature can be found: #18730 Note: internet access is required during the build for this optimization to work.
clydin
approved these changes
Oct 14, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we inline Google fonts and icons in the index html file when optimization is enabled.
Before
After
To opt-out of this feature set
optimization.fonts: falseoroptimization.fonts.inline: falsein the browser builder options.Example:
More information about the motivation for this feature can be found: #18730
Note: internet access is required during the build for this optimization to work.