Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): collect analytics option usage from workspace config and prompts #18982

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix(@angular/cli): collect analytics option usage from workspace config and prompts #18982

merged 1 commit into from
Oct 7, 2020

Conversation

alan-agius4
Copy link
Collaborator

With this change we fix two analytics collection bugs:

  • We now collect the usage of options defined in the workspace config (angular.json).
  • We now also collect values set via schematic prompts.

Closes: #17900

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 6, 2020
…ig and prompts

With this change we fix two analytics collection bugs:
- We now collect the usage of options defined in the workspace config (angular.json).
- We now also collect values set via schematic prompts.

Closes: #17900
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2020
@clydin clydin merged commit 90988aa into angular:master Oct 7, 2020
@alan-agius4 alan-agius4 deleted the analytics-architect-command branch October 7, 2020 14:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analytics reports only contains options passed via the command line
3 participants