Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): add generation for resolvers #19048

Merged
merged 1 commit into from Oct 15, 2020

Conversation

Jefiozie
Copy link
Contributor

This will add the resolvers as an option to generate.
You can use it by ng g r <name> or ng generate resolver <name>

closes: #17569

@google-cla google-cla bot added the cla: yes label Oct 11, 2020
@Jefiozie
Copy link
Contributor Author

Just referencing @alan-agius4 or @clydin for reviewing 😄

@kyliau kyliau added the needs: discussion On the agenda for team meeting to determine next steps label Oct 12, 2020
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, one small NIT.

packages/schematics/angular/resolver/schema.json Outdated Show resolved Hide resolved
packages/schematics/angular/resolver/index.ts Outdated Show resolved Hide resolved
packages/schematics/angular/resolver/index.ts Outdated Show resolved Hide resolved
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: major This PR is targeted for the next major release and removed needs: discussion On the agenda for team meeting to determine next steps labels Oct 12, 2020
@Jefiozie
Copy link
Contributor Author

Will make these changes as soon as i have some time.

@Jefiozie
Copy link
Contributor Author

Hey @alan-agius4, I have changed your comments, I think it is good to do a quick review again. Thanks for your comments.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 14, 2020
@alan-agius4
Copy link
Collaborator

Thanks for your contribution @Jefiozie.

@Jefiozie
Copy link
Contributor Author

Thank you, hope to do some more contributions.

@alan-agius4 alan-agius4 merged commit 45c0b50 into angular:master Oct 15, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(generate): generate resolver
3 participants