Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): resolve packages package.json from workspace directory #19071

Merged
merged 2 commits into from Oct 14, 2020
Merged

fix(@angular/cli): resolve packages package.json from workspace directory #19071

merged 2 commits into from Oct 14, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 14, 2020

Unlike require.resolve, the resolve package paths is only used as a fallback when the package is not resolved from the basedir,

Previously this resulted in the temporary version of CLI being resolved here which resulted in ng update incorrectly stating that there are no updates.

@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed cla: yes labels Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
@alan-agius4
Copy link
Collaborator Author

Mentioned in #19058 (comment)

@angular angular deleted a comment from google-cla bot Oct 14, 2020
@alan-agius4 alan-agius4 changed the title fix(@angular/cli): resolve @angular/cli package.json from workspace directory fix(@angular/cli): resolve packages package.json from workspace directory Oct 14, 2020
…tory

Unlike `require.resolve`, the `resolve` package `paths` is only used as a fallback when the package is not resolved from the `basedir`,

Previously this resulted in the temporary version of CLI being resolved here which resulted in `ng update` incorrectly stating that there are no updates.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 14, 2020
@filipesilva filipesilva merged commit 4e22443 into angular:master Oct 14, 2020
@alan-agius4 alan-agius4 deleted the update-imp-fix branch October 14, 2020 14:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants