Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): support jit mode guarded class metadata removal #19076

Merged
merged 2 commits into from Oct 15, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 14, 2020

This adds support for an alternate emit form of ɵsetClassMetadata that is guarded by ngJitMode instead of a pure annotation.

This adds support for the alternate emit form of `ɵsetClassMetadata` that is guarded by `ngJitMode` instead of a pure annotation.
@clydin clydin added the target: major This PR is targeted for the next major release label Oct 14, 2020
@google-cla google-cla bot added the cla: yes label Oct 14, 2020
…metadata removal

This adds support for the alternate emit form of `ɵsetClassMetadata` that is guarded by `ngJitMode` instead of a pure annotation.
@alan-agius4 alan-agius4 added effort2: medium (days) action: merge The PR is ready for merge by the caretaker labels Oct 15, 2020
@alan-agius4 alan-agius4 merged commit 2f45677 into angular:master Oct 15, 2020
@clydin clydin deleted the ivy-metadata-jit-guard branch October 15, 2020 12:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker effort2: medium (days) target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants