Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n - implement duplicateMessageHandling in message extraction #19207

Closed
petebacondarwin opened this issue Oct 25, 2020 · 2 comments · Fixed by #19266
Closed

i18n - implement duplicateMessageHandling in message extraction #19207

petebacondarwin opened this issue Oct 25, 2020 · 2 comments · Fixed by #19266

Comments

@petebacondarwin
Copy link
Member

The extractor supports an option to report warnings/errors if there are messages with the same id but different message text.

See https://github.com/angular/angular/blob/79620f5139c80f1b3b38168744ca99a224c7e5cd/packages/localize/src/tools/src/extract/main.ts#L89-L95

Exposing this via the CLI integration would help to avoid confusing issues like angular/angular#39227.

@petebacondarwin petebacondarwin added feature Issue that requests a new feature target: major This PR is targeted for the next major release devkit/build-angular:i18n labels Oct 25, 2020
@alan-agius4 alan-agius4 added area: devkit/build-angular and removed target: major This PR is targeted for the next major release labels Oct 25, 2020
@ngbot ngbot bot modified the milestone: Backlog Oct 25, 2020
@AndrewKushnir
Copy link

I think it'd be great to set the default value to "warning" (as we have it on the framework side), so that we surface this error to users without the need to configure it.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants