Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): apply local libraries sourcemap without vendor: true #19446

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

alan-agius4
Copy link
Collaborator

With this change we apply sourcemaps of libraries in a monorepo without the need to enable vendor: true. This is more intuitive behavior and in line with what the users expect.

We also suppress the Failed to parse source map from in-actionable warning.

Closes #11305

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 20, 2020
@google-cla google-cla bot added the cla: yes label Nov 20, 2020
…ithout `vendor: true`

With this change we apply sourcemaps of libraries in a monorepo without the need to enable `vendor: true`. This is more intuitive behavior and  in line with what the users expect.

We also suppress the `Failed to parse source map from` in-actionable warning.

Closes #11305
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Nov 20, 2020
@filipesilva filipesilva merged commit d71ee21 into angular:master Nov 24, 2020
@filipesilva
Copy link
Contributor

@alan-agius4 this PR does not apply cleanly to patch. Can you make a new one please?

@alan-agius4 alan-agius4 deleted the lib-sourcemaps branch November 24, 2020 13:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to exclude certain files from sourcemap.
3 participants