Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace broken link #19932

Merged
merged 1 commit into from Feb 2, 2021

Conversation

destus90
Copy link
Contributor

@destus90 destus90 commented Feb 2, 2021

There is a broken link inside ng new section (https://angular.io/cli/new). When you click on that link, placed next to strict option, you are redirected to 404 (Page not found).

@google-cla google-cla bot added the cla: yes label Feb 2, 2021
@alan-agius4
Copy link
Collaborator

Thanks for this.

https://angular.io/strict is a redirection to https://angular.io/guide/strict-mode both of which are valid links.

I think the problem is that in the docs the redirection is not happening because both hosts are the same and therefore routing will be handled by Angular when the link is in angular.io.

Let me have a chat with the docs-infra folks before doing any changes.

Rectifies a broken link into `ng new` section.
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 2, 2021
@alan-agius4 alan-agius4 merged commit 1af01d2 into angular:master Feb 2, 2021
@destus90 destus90 deleted the destus90-broken-strict-link branch February 2, 2021 16:42
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants