Typescript Broccoli Plugin doesn't pass error message to broccoli #1
Comments
|
I landed this in angular master: angular/angular@a7ea2e5 |
|
This issue seems to be resolved. If it is not, feel free to reopen it. |
hansl
pushed a commit
that referenced
this issue
Jul 7, 2016
* added project args to config * Refactored configs to a single class and instance for env and path reasons * Updated the ng serve command to respect the new class instance 🔥
TheLarkInn
pushed a commit
that referenced
this issue
Jul 12, 2016
Squashed commits: [0afb2e8] Bump Typescript version to 2.0 Beta and now with compatible support awesome-typescript-loader 2.0. [2527559] Updated the Module resolution strategy. It looks like awesome-ts-loader doesn't like it, however when I implement the plugin it still works correctly. Need to tell a-t-l to stop trying to resolve itself. [0b9a567] Added support to resolve modules using ts. path mapping strategy (#3) [37c9885] Removed autoprefixer which isn't used for right now, will discuss reimplement [ed1c7fa] Initial commit of fixed path mappings for awesome-typescript-loader v1.1.1. We could use it across the board. Maybe. [2ec0492] Initial commit of fixed path mappings for awesome-typescript-loader v1.1.1. We could use it across the board. Maybe. [c7ca12e] Now build commands actually rimraf the dist folder, and assets truly land in root path of dist instead of dist/public [aea7447] Updated typings to 1.3.1, removed unneeded stuff, and fixed testing output [7ca3196] updated tests to pass automatically because of some coverage and types issues [e3e4fd0] Fixed webpack version [3b5d310] backdated webpack version mistake [d023803] Updated webpack version [829027b] Set default tsconfig to use es6->es5 [4457e1e] Removed ngAppResolve() which had process.cwd() instead of project.root from tests. [a734c98] Removed code that was originally being inlined for dev server that now doesn't need to be inlined. Now ng serve should just _work_ for mobile builds and caching should also work correctly, EDIT: forgot to uncomment the optimizations for prod [31d6d7a] Removed code that was originally being inlined for dev server that now doesn't need to be inlined. Now ng serve should just _work_ for mobile builds and caching should also work correctly [a59eed3] fix some e2e tests, simplify mobile prod build [9a7a4d5] fix require error Fix an initialization error affecting tests. [0e83b8f] feat(build): add mobile app build (#2) [d52fb7f] Feature/new root directory syntax (#1) * added project args to config * Refactored configs to a single class and instance for env and path reasons * Updated the ng serve command to respect the new class instance 🔥 [681918f] updated typescript nightly dependency [b75539e] Updated test configuration to include needed asset loaders. [0159123] chore(testing) modified the awesome typescript loader config to output es5 modules and not es6, breaks istanbuls esprima dep. Should look into isparta. [44234e6] bugfix(atl) fixed an issue where template loader wasn't transforming ts files [a36071e] Reversed DLL Plugin work. This is 1.1+ work. [19d6e62] Added DLL plugin and @angularclas/webpack-tool kit for some pun plans to use. [f61ec80] added a missing import statement that appears it would break mobile mode if I actually tested it [cf6f3bb] Updated the material2build common config to use e2e path instead of demo-app path. This allows tests to actually run and the app to build as expected [c0c1f16] Enabled support for both material2 e2e testing but also demo-app and e2e app and sped builds slightly. Material Demo app is still painfully slow due to definitions being generated. [a9d12ed] Enabled support for both material2 e2e testing but also demo-app and e2e app. [d166b65] Added e2d support to maetieral2 [ce808d9] Finally got the material2 config to build. Had to change a few material2 things but got it working, builds are not the fastest because of using ts-loader. I definitiely don't like that [d16bb43] separated additional files for material2 [91adadb] separated additional files for material2 [5c3067f] Experimental testing with material 2 [171580e] having sourcemap settings breaks the e2e testing with nightly typescript and ts-node version, this fixes this problem [a904905] fixed typo [f999056] chore(test) get tests working again, e2e still WIP, but added non-exposed support for webpack-karma as well as a variety of better looking reporters with mocha and coverage through istanbul. Sourcemaps still WIP for debugging tests. [b3e8c59] Tests more shelled out, still not running correctly but I'm much closer [1424c38] Tests more shelled out, still not running correctly but I'm much closer [302c81e] New typings file for custom interfaces and modules [1b4a911] Added all the plim things that needed to be added. Tests still fail but I think I'm on my way [55920f5] Updated dependencies cherry picked from master [ae34af8] Removing file loader but leaving deps [782c6f3] Added asset copying onto page. WIPWIPWIP [b81f42b] Updated config some more, held off on testing until more deliberation tomorrow [5985eeb] Updated loaders to add sourcemap support as well as supporting stylus etc [562d617] Added all the styles to things [8ccc7d2] chore(test) Added a crapton of node-modules for the entire testing suite. [2882ce6] updated deps and attempting to get a-t-loader to work with ts@next [60fb36a] Added serve task as well as some interfaces for safer maintainability [6c1c956] Added watch mode, partial work on webpack-dev-server for ng serve [0136a8e] rearranged code into appropriate task/command/models folders [dbfaf76] bugfix(webpack) fixed template syntax error && forced upgrade to webpack@2.1.0-beta.12 for lots of awesome enhancements [fda7743] chore(webpack) cleaned up the html interpolation thats broken from gutting the old builder [d897f8f] chore(webpack) added typing for require for template loader [c2868df] fix(removed obsolete typings reference) [018770d] feat(build) Swapping out build system for Webpack: Implement 3bundles shared and split, along with CLI output and feedback and reporting. And template compilation for inline html and css. [f1a25c0] Added webpack as build system, trying to split out to vendors but oddly not loading. Webpack I think is eating the Decorators [4baf9cd] build: introduce webpack instead of broccoli in the build Added webpack as build system, trying to split out to vendors but oddly not loading. Webpack I think is eating the Decorators feat(build) Swapping out build system for Webpack: Implement 3bundles shared and split, along with CLI output and feedback and reporting. And template compilation for inline html and css. fix(removed obsolete typings reference) chore(webpack) added typing for require for template loader chore(webpack) cleaned up the html interpolation thats broken from gutting the old builder bugfix(webpack) fixed template syntax error && forced upgrade to webpack@2.1.0-beta.12 for lots of awesome enhancements rearranged code into appropriate task/command/models folders Added watch mode, partial work on webpack-dev-server for ng serve Added serve task as well as some interfaces for safer maintainability updated deps and attempting to get a-t-loader to work with ts@next chore(test) Added a crapton of node-modules for the entire testing suite. Added all the styles to things Updated loaders to add sourcemap support as well as supporting stylus etc Updated config some more, held off on testing until more deliberation tomorrow Added asset copying onto page. WIPWIPWIP Removing file loader but leaving deps Updated dependencies cherry picked from master Added all the plim things that needed to be added. Tests still fail but I think I'm on my way New typings file for custom interfaces and modules Tests more shelled out, still not running correctly but I'm much closer Tests more shelled out, still not running correctly but I'm much closer chore(test) get tests working again, e2e still WIP, but added non-exposed support for webpack-karma as well as a variety of better looking reporters with mocha and coverage through istanbul. Sourcemaps still WIP for debugging tests. fixed typo having sourcemap settings breaks the e2e testing with nightly typescript and ts-node version, this fixes this problem Experimental testing with material 2 separated additional files for material2 separated additional files for material2 Finally got the material2 config to build. Had to change a few material2 things but got it working, builds are not the fastest because of using ts-loader. I definitiely don't like that Added e2d support to maetieral2 Enabled support for both material2 e2e testing but also demo-app and e2e app. Enabled support for both material2 e2e testing but also demo-app and e2e app and sped builds slightly. Material Demo app is still painfully slow due to definitions being generated. Updated the material2build common config to use e2e path instead of demo-app path. This allows tests to actually run and the app to build as expected added a missing import statement that appears it would break mobile mode if I actually tested it Added DLL plugin and @angularclas/webpack-tool kit for some pun plans to use. Reversed DLL Plugin work. This is 1.1+ work. bugfix(atl) fixed an issue where template loader wasn't transforming ts files chore(testing) modified the awesome typescript loader config to output es5 modules and not es6, breaks istanbuls esprima dep. Should look into isparta. Updated test configuration to include needed asset loaders. updated typescript nightly dependency Feature/new root directory syntax (#1) * added project args to config * Refactored configs to a single class and instance for env and path reasons * Updated the ng serve command to respect the new class instance 🔥 feat(build): add mobile app build (#2) fix require error Fix an initialization error affecting tests. fix some e2e tests, simplify mobile prod build Removed code that was originally being inlined for dev server that now doesn't need to be inlined. Now ng serve should just _work_ for mobile builds and caching should also work correctly Removed code that was originally being inlined for dev server that now doesn't need to be inlined. Now ng serve should just _work_ for mobile builds and caching should also work correctly, EDIT: forgot to uncomment the optimizations for prod Removed ngAppResolve() which had process.cwd() instead of project.root from tests. Set default tsconfig to use es6->es5 Updated webpack version backdated webpack version mistake Fixed webpack version updated tests to pass automatically because of some coverage and types issues Updated typings to 1.3.1, removed unneeded stuff, and fixed testing output Now build commands actually rimraf the dist folder, and assets truly land in root path of dist instead of dist/public Initial commit of fixed path mappings for awesome-typescript-loader v1.1.1. We could use it across the board. Maybe. Initial commit of fixed path mappings for awesome-typescript-loader v1.1.1. We could use it across the board. Maybe. Removed autoprefixer which isn't used for right now, will discuss reimplement Added support to resolve modules using ts. path mapping strategy (#3) Updated the Module resolution strategy. It looks like awesome-ts-loader doesn't like it, however when I implement the plugin it still works correctly. Need to tell a-t-l to stop trying to resolve itself. Bump Typescript version to 2.0 Beta and now with compatible support awesome-typescript-loader 2.0. Another slight change
This was referenced Aug 11, 2016
15 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current version of the broccoli-typescript plugin directly logs any compiler error to the console, using
console.log, instead of throwing it for Broccoli to catch.We need to change this so whenever we
broccoli serveorng servea project, broccoli can output any compilation errors to the browser for the user to see when reloading the page./cc @IgorMinar
The text was updated successfully, but these errors were encountered: