Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental rollup pass #20007

Merged
merged 3 commits into from Feb 9, 2021
Merged

Remove experimental rollup pass #20007

merged 3 commits into from Feb 9, 2021

Conversation

alan-agius4
Copy link
Collaborator

refactor(@angular-devkit/build-angular): remove experimental rollup pass

The experimental rollup pass has significant issues with the new Ivy webpack plugin. It also, didn't produce as well as we hoped in real world scenarios infact in many cases this caused build to fail.

REAKING CHANGE:

The experimental rollup pass --experimental-rollup-pass option has been removed.

Closes #15836

feat(@schematics/angular): add migration to remove deprecated options from 'angular.json'

refactor(@ngtools/webpack): remove export of VirtualFileSystemDecorator type

This was only needed for the rollup loader.

@google-cla google-cla bot added the cla: yes label Feb 9, 2021
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed cla: yes labels Feb 9, 2021
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
The experimental rollup pass has significant issues with the new Ivy webpack plugin. It also, didn't produce as well as we hoped in real world scenarios infact in many cases this caused build to fail.

REAKING CHANGE:

The experimental rollup pass `--experimental-rollup-pass` option has been removed.

Closes #15836
…tor` type

This was only needed for the rollup loader.
@angular angular deleted a comment from google-cla bot Feb 9, 2021
@clydin clydin merged commit f424529 into angular:master Feb 9, 2021
@alan-agius4 alan-agius4 deleted the rollup-pass-remove branch February 9, 2021 14:00
@Splaktar
Copy link
Member

@alan-agius4 There is a typo in the commit that might cause this breaking change to not be reflected in the CHANGELOG:

REAKING CHANGE:

Instead of

BREAKING CHANGE:

Indeed, I don't see this breaking change in https://github.com/angular/angular-cli/releases/tag/v12.0.0-next.0 where the commit was included.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--experimentalRollupPass feedback issue
3 participants