Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): enable inlineCritical by default #20096

Merged
merged 1 commit into from Feb 26, 2021
Merged

feat(@angular-devkit/build-angular): enable inlineCritical by default #20096

merged 1 commit into from Feb 26, 2021

Conversation

alan-agius4
Copy link
Collaborator

BREAKING CHANGE:

Critical CSS inlining is now enabled by default. If you wish to turn this off set inlineCritical to false.

See: https://angular.io/guide/workspace-config#optimization-configuration

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Feb 19, 2021
@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@alan-agius4 alan-agius4 changed the title feat(@angular-devkit/buid-angular): enable inlineCritical by default feat(@angular-devkit/build-angular): enable inlineCritical by default Feb 19, 2021
BREAKING CHANGE:

Critical CSS inlining is now enabled by default. If you wish to turn this off set `inlineCritical` to `false`.

See: https://angular.io/guide/workspace-config#optimization-configuration
@rhutchison
Copy link

@alan-agius4 inlineCritical doesn't play well with tailwind @apply rules. Has there been anything raised or discussed internally regarding this issue?

What I've noticed is that the css that gets pushed inline has not gone through the tailwind pre-processor.

@alan-agius4
Copy link
Collaborator Author

@rhutchison, no one brought up any issues with inlining of critical CSS. That said, the inlining of critical CSS is done post processing the stylesheets.

If there is any issue please file an issue with a reproduction in the issue tracker. Thanks.

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 26, 2021
@clydin clydin merged commit aa3ea88 into angular:master Feb 26, 2021
@alan-agius4 alan-agius4 deleted the enable-inline-critical-css branch February 26, 2021 18:23
zarend pushed a commit to angular/angular that referenced this pull request Feb 26, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants