Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use specific git add command to avoid adding unnecessary files #20136

Merged
merged 1 commit into from Feb 25, 2021

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Feb 24, 2021

Today when releasing v9 and v10, I found two extra files in Git (.husky/ and .ng-dev.log). These are a part of the toolchain in later versions, but not known ignored in older versions. Using git commit -a would have included both of those files in the release commit which would not be desirable. Instead, the solution for releases is to add the specific files that are modified to remove this possibility.

I'll do a separate PR to back-port the .gitignore updates to those branches and start a broader discussion about how we should manage .gitignore for LTS branches.

cc @kyliau @josephperrott for visibility to other caretakers.

Today when releasing v9 and v10, I found two extra files in Git (`.husky/` and `.ng-dev.log`). These are a part of the toolchain in later versions, but not known ignored in older versions. Using `git commit -a` would have included both of those files in the release commit which would not be desirable. Instead, the solution for releases is to add the specific files that are modified to remove this possibility.
@dgp1130 dgp1130 added the area: docs Related to the documentation label Feb 24, 2021
@dgp1130 dgp1130 requested a review from kyliau February 24, 2021 20:18
@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Feb 25, 2021

Charles pointed out that git add . doesn't apply to untracked files (untracked vs. unstaged strikes again!), so it likely would not have been an issue in this case. Nonetheless, I think this is still worth merging if for no other reason than to reminder releasers that other changes might be accidentally included as well.

@dgp1130 dgp1130 added the action: merge The PR is ready for merge by the caretaker label Feb 25, 2021
@clydin clydin added the target: major This PR is targeted for the next major release label Feb 25, 2021
@clydin clydin merged commit 072abbe into master Feb 25, 2021
@dgp1130 dgp1130 deleted the dgp1130-release-doc-git-add branch February 25, 2021 22:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants