test(@angular/cli): reuse chrome/chromedriver in E2E tests #20148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
e2e/chromedriver
branch
3 times, most recently
from
3896398
to
939ea40
Compare
This changes the E2E test project setup to reuse the repository's existing puppeteer chrome instance and already downloaded chrome driver. Previously puppeteer was added to each E2E test project which required an additional download of both chrome and an associated chromedriver. Downloads previously needed to occur multiple times during the test process due to tests changing/removing the test project's node modules directory.
clydin
force-pushed
the
e2e/chromedriver
branch
from
939ea40
to
9cdd5d2
Compare
alan-agius4
approved these changes
Feb 26, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the E2E test project setup to reuse the repository's existing puppeteer chrome instance and already downloaded chrome driver. Previously puppeteer was added to each E2E test project which required an additional download of both chrome and an associated chromedriver. Downloads previously needed to occur multiple times during the test process due to tests changing/removing the test project's node modules directory.