Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular-devkit/build-angular): use custom babel loader for i18n dev-server support #20172

Merged
merged 1 commit into from Mar 2, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 1, 2021

The custom babel loader allows files to be conditionally processed by the i18n inlining transforms based on both file path and content.
By allowing content based checks, the entire babel parse/transform/print process can be skipped for files that do not contain localizations.

Closes: #18398

…i18n dev-server support

The custom babel loader allows files to be conditionally processed by the i18n inlining transforms based on both file path and content.
By allowing content based checks, the entire parse/transform/print process can be skipped for files that do not contain localizations.
@clydin clydin added the target: major This PR is targeted for the next major release label Mar 1, 2021
@google-cla google-cla bot added the cla: yes label Mar 1, 2021
@clydin clydin requested a review from alan-agius4 March 1, 2021 18:05
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might solve #18398 can you please check?

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 2, 2021
@clydin clydin added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Mar 2, 2021
@clydin clydin merged commit e1b3ee6 into angular:master Mar 2, 2021
@clydin clydin deleted the i18n-serve-loader branch March 2, 2021 19:07
@DmitryEfimenko
Copy link

I noticed that this commit has the following tags: v12.0.0-next.5 v12.0.0-next.4 v12.0.0-next.3

Is there a breaking change in this commit that prevents it to be released in an earlier version?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out of memory on ng serve with i18n and targeting es5
3 participants