Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@ngtools/webpack): drop support for string based lazy loading #20222

Merged
merged 7 commits into from Mar 10, 2021
Merged

feat(@ngtools/webpack): drop support for string based lazy loading #20222

merged 7 commits into from Mar 10, 2021

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 9, 2021

BREAKING CHANGE:

With this change we drop support for string based lazy loading ./lazy.module#LazyModule use dynamic imports instead.

The following options which were used to support the above syntax were removed without replacement.

  • discoverLazyRoutes
  • additionalLazyModules
  • additionalLazyModuleResources
  • contextElementDependencyConstructor

closes #12476

@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Mar 9, 2021
@alan-agius4 alan-agius4 requested a review from clydin March 9, 2021 15:46
@alan-agius4 alan-agius4 marked this pull request as ready for review March 9, 2021 15:46
@alan-agius4 alan-agius4 requested a review from clydin March 9, 2021 19:00
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 9, 2021
@alan-agius4 alan-agius4 removed the action: merge The PR is ready for merge by the caretaker label Mar 10, 2021
BREAKING CHANGE:

With this change we drop support for string based lazy loading `./lazy.module#LazyModule`  use dynamic imports instead.

The following options which were used to support the above syntax were removed without replacement.
- discoverLazyRoutes
- additionalLazyModules
- additionalLazyModuleResources
- contextElementDependencyConstructor
…es` option

BREAKING CHANGE:

Server and Browser builder `lazyModules` option has been removed without replacement.
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2021
@filipesilva filipesilva merged commit 1e9881b into angular:master Mar 10, 2021
@alan-agius4 alan-agius4 deleted the string-lazy-loading-remove branch March 10, 2021 18:47
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng serve: Support windows paths properly
3 participants