New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@ngtools/webpack): drop support for string based lazy loading #20222
Merged
filipesilva
merged 7 commits into
angular:master
from
alan-agius4:string-lazy-loading-remove
Mar 10, 2021
Merged
feat(@ngtools/webpack): drop support for string based lazy loading #20222
filipesilva
merged 7 commits into
angular:master
from
alan-agius4:string-lazy-loading-remove
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
This PR is targeted for the next major release
label
Mar 9, 2021
clydin
reviewed
Mar 9, 2021
packages/angular_devkit/build_angular/src/webpack/configs/common.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Mar 9, 2021
BREAKING CHANGE: With this change we drop support for string based lazy loading `./lazy.module#LazyModule` use dynamic imports instead. The following options which were used to support the above syntax were removed without replacement. - discoverLazyRoutes - additionalLazyModules - additionalLazyModuleResources - contextElementDependencyConstructor
…es` option BREAKING CHANGE: Server and Browser builder `lazyModules` option has been removed without replacement.
…iguration option
…g syntax to use dynamic imports
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
With this change we drop support for string based lazy loading
./lazy.module#LazyModule
use dynamic imports instead.The following options which were used to support the above syntax were removed without replacement.
closes #12476