Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-webpack): provide output path in builder results #20266

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 14, 2021

This change adds the output path for the Webpack build directly to the result of the builder. This removes one of the reasons for using the Webpack JSON stats object which is expensive to generate.

…esults

This change adds the output path for the Webpack build directly to the result of the builder. This removes one of the reasons for using the Webpack JSON stats object which is expensive to generate.
…rovided output path

By using the output path provided directly by the Webpack builder's result, one additional reason for using the expensive `Stats.toJson` call is removed.
This change also removes multiple linting disable rule comments now that the output path property is guaranteed to be present.
@clydin clydin added the target: major This PR is targeted for the next major release label Mar 14, 2021
@google-cla google-cla bot added the cla: yes label Mar 14, 2021
@clydin clydin requested a review from alan-agius4 March 14, 2021 15:42
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2021
@alan-agius4 alan-agius4 merged commit 6fd4da2 into angular:master Mar 15, 2021
@clydin clydin deleted the webpack-plugin/perf-webpack-stats-2 branch March 15, 2021 16:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants