Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): only run emitDecoratorMetadata removal migration in safe workspaces #20686

Merged
merged 1 commit into from May 4, 2021
Merged

fix(@schematics/angular): only run emitDecoratorMetadata removal migration in safe workspaces #20686

merged 1 commit into from May 4, 2021

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented May 4, 2021

Removal of emitDecoratorMetadata might cause runtime errors on projects which don't use the Angular Compiler to compile TypeScript code and therefore dependent on Decorators metadata during runtime. One such example of these builders is @nrwl/jest.

@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label May 4, 2021
@google-cla google-cla bot added the cla: yes label May 4, 2021
…gration in safe workspaces

Removal of `emitDecoratorMetadata` might cause runtime errors on projects which don't use the Angular Compiler to compile TypeScript code and therefore dependent on Decorators metadata during runtime.  One such example of these builders is `@nrwl/jest`.
@alan-agius4 alan-agius4 requested a review from clydin May 4, 2021 11:04
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 4, 2021
@clydin clydin merged commit 7521a87 into angular:master May 4, 2021
@alan-agius4 alan-agius4 deleted the emit-decorator-migration branch May 4, 2021 15:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants