Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(@angular-devkit/build-webpack): include only required stats in webpackStats #21010

Merged
merged 1 commit into from Jun 2, 2021
Merged

perf(@angular-devkit/build-webpack): include only required stats in webpackStats #21010

merged 1 commit into from Jun 2, 2021

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jun 1, 2021

Until we depend on webpackStats in the browser builder we should only included the required stats.

The below are the needed stats;

all: false,
colors: true,
hash: true,
timings: true,
chunks: true,
builtAt: true,
warnings: true,
errors: true,
assets: true,
ids: true,
entrypoints: true,

@google-cla google-cla bot added the cla: yes label Jun 1, 2021
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 1, 2021
@alan-agius4 alan-agius4 requested review from clydin and JoostK June 1, 2021 11:39
Copy link
Member

@JoostK JoostK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not fully qualified to review this but the change LGTM.

@alan-agius4
Copy link
Collaborator Author

I am not fully qualified to review this but the change LGTM.

Haha, yeah, just wanted to share since we were talking about this.

@alan-agius4 alan-agius4 marked this pull request as draft June 1, 2021 14:11
@alan-agius4 alan-agius4 closed this Jun 1, 2021
@alan-agius4 alan-agius4 reopened this Jun 1, 2021
@alan-agius4 alan-agius4 marked this pull request as ready for review June 1, 2021 14:38
…ebpackStats

Until we depend on `webpackStats` in the browser builder we should only included the required stats.

The below are the needed stats;
```
    all: false,
    colors: true,
    hash: true,
    timings: true,
    chunks: true,
    builtAt: true,
    warnings: true,
    errors: true,
    assets: true,
    ids: true,
    entrypoints: true,
```
@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin June 2, 2021 11:15
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 2, 2021
@alan-agius4 alan-agius4 merged commit 023d093 into angular:master Jun 2, 2021
@alan-agius4 alan-agius4 deleted the stats-webpack-builder branch June 2, 2021 16:25
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants