Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@ngtools/webpack): create ngcc resolver from Webpack Compiler #21090

Merged
merged 1 commit into from Jun 9, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 9, 2021

By using the Webpack compiler to request a resolver, configuration supplied options will automatically be used (such as symlinks) and also ensures that the same version of the resolver code will be used. Additionally, this removes one of the reasons to directly depend on the enhanced-resolve package.

By using the Webpack compiler to request a resolver, configuration supplied options will automatically be used (such as symlinks) and also ensures that the same version of the resolver code will be used. Additionally, this removes one of the reasons to directly depend on the `enhanced-resolve` package.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jun 9, 2021
@google-cla google-cla bot added the cla: yes label Jun 9, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 9, 2021
@alan-agius4 alan-agius4 merged commit bf11f2b into angular:master Jun 9, 2021
@clydin clydin deleted the ngtools/ngcc-resolver branch June 9, 2021 09:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants