Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(@angular/cli): Add Nightwatch schematics to e2e command #21096

Conversation

vaibhavsingh97
Copy link
Contributor

Overview
Added Nightwatch Schematic to e2e command. Nightwatch schematics would add both schematics and custom builder to Angular Project.

Ref:
https://github.com/nightwatchjs/nightwatch-schematics
https://www.npmjs.com/package/@nightwatch/schematics

@google-cla google-cla bot added the cla: yes label Jun 9, 2021
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since this appears to be a supported by nightwatch.

That said, I'll going to mark this for further discussion just to make sure that everyone on the team is onboard with this.

@alan-agius4 alan-agius4 added needs: discussion On the agenda for team meeting to determine next steps target: patch This PR is targeted for the next patch release labels Jun 9, 2021
@AutomatedTester
Copy link

Hi @alan-agius4 and @kyliau

Is there anything else we(@vaibhavsingh97 or myself) can do here to get the update landed?

@alan-agius4
Copy link
Collaborator

@dgp1130 reached out to our devrels @twerske and @mgechev to see if there is any concern from their end about this change.

@mgechev
Copy link
Member

mgechev commented Jun 22, 2021

No concerns on our end. Our general policy is to have a set of e2e tests running against the lasted build artifacts. You can keep up to date with renovatebot. Since the builder is already maintained by your team, we'd love to have it as an option.

@AutomatedTester
Copy link

@mgechev We have https://github.com/nightwatchjs/nightwatch-schematics/blob/main/src/schematics/nightwatch/index_spec.ts. Would you want us to add tests to this repo or are those good enough? We're happy to add in anything you suggest here.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed needs: discussion On the agenda for team meeting to determine next steps labels Jun 23, 2021
@filipesilva filipesilva merged commit 4ce7681 into angular:master Jun 24, 2021
@vaibhavsingh97 vaibhavsingh97 deleted the feat/add-nightwatch-schematic-command branch June 24, 2021 13:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants