Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): control linker template sourcemapping via builder sourcemap options #21155

Merged
merged 1 commit into from Jun 21, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 17, 2021

This change allows the linker sourcemap behavior to be controlled by the Webpack sourcemap configuration. For example, if a vendor file is being processed and vendor sourcemaps are disabled, the linker will now skip its internal sourcemap loading and processing steps.

…ping via builder sourcemap options

This change allows the linker sourcemap behavior to be controlled by the Webpack sourcemap configuration. For example, if a vendor file is being processed and vendor sourcemaps are disabled, the linker will now skip its internal sourcemap loading and processing steps.
@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 17, 2021
@google-cla google-cla bot added the cla: yes label Jun 17, 2021
@clydin clydin marked this pull request as ready for review June 18, 2021 13:04
@clydin clydin requested a review from alan-agius4 June 18, 2021 13:04
Copy link
Member

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 18, 2021
@filipesilva filipesilva merged commit d4c5f85 into angular:master Jun 21, 2021
@filipesilva
Copy link
Contributor

@clydin this PR has a conflict when being applied to 12.0.x.. Can you create a new PR that fixes this conflict please?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants