refactor(@angular-devkit/build-angular): use Webpack provided loader types #21273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Jul 2, 2021
alan-agius4
reviewed
Jul 2, 2021
packages/angular_devkit/build_angular/src/extract-i18n/ivy-extract-loader.ts
Show resolved
Hide resolved
…types Webpack now provides loader function type definitions. These type definitions are now used in custom loaders within the package. This improves type safety and behavior correctness of the loaders when used with Webpack.
clydin
force-pushed
the
webpack-loader-types
branch
from
bf513a0
to
1936df6
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack now provides loader function type definitions. These type definitions are now used in custom loaders within the package.
This improves type safety and behavior correctness of the loaders when used with Webpack.
The direct usage of the
loader-utilspackage is also reduced as the Webpack 5 loader context now provides thegetOptionsfunction.