Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): use a helper function for basic generation schematics #21344

Merged

Conversation

clydin
Copy link
Member

@clydin clydin commented Jul 14, 2021

An internal schematics helper rule has been introduced for Angular schematics that only generate a set of project files from a set of templated files. Multiple current generation schematics contained essentially the same code which increased the sustainment burden and made refactoring and improvements more complicated.

…tion schematics

An internal schematics helper rule has been introduced for Angular schematics that only generate a set of project files from a set of templated files. Multiple current generation schematics contained essentially the same code which increased the sustainment burden and made refactoring and improvements more complicated.
@clydin clydin added the target: minor This PR is targeted for the next minor release label Jul 14, 2021
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@clydin clydin requested a review from alan-agius4 July 14, 2021 18:06
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jul 15, 2021
@alan-agius4 alan-agius4 merged commit 2b14ac6 into angular:master Jul 15, 2021
@clydin clydin deleted the schematics/angular-basic-refactor branch July 15, 2021 11:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants