Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove last string-form loadChildren usage #21848

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Sep 30, 2021

One E2E test was still using the deprecated string-form of the routing loadChildren property. The loadChildren usage has now been converted to use the suppported dynamic import form. The string-form has been removed from Angular v13.

One E2E test was still using the deprecated string-form of the routing `loadChildren` property. The `loadChildren` usage has now been converted to use the suppported dynamic import form. The string-form has been removed from Angular v13.
@clydin clydin added the target: major This PR is targeted for the next major release label Sep 30, 2021
@google-cla google-cla bot added the cla: yes label Sep 30, 2021
@dgp1130 dgp1130 self-requested a review September 30, 2021 22:53
@dgp1130 dgp1130 merged commit 5b0fa75 into angular:master Sep 30, 2021
@clydin clydin deleted the e2e/fix-string-load-children branch September 30, 2021 23:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants